1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
|
/*
* Copyright 2025 LunarG, Inc.
* Copyright 2025 Google LLC
* SPDX-License-Identifier: MIT
*/
#include "kk_encoder.h"
#include "kk_bo.h"
#include "kk_cmd_buffer.h"
#include "kk_queue.h"
#include "kosmickrisp/bridge/mtl_bridge.h"
#include "kosmickrisp/bridge/vk_to_mtl_map.h"
#include "cl/kk_query.h"
static void
kk_encoder_start_internal(struct kk_encoder_internal *encoder,
mtl_device *device, mtl_command_queue *queue)
{
encoder->cmd_buffer = mtl_new_command_buffer(queue);
encoder->last_used = KK_ENC_NONE;
util_dynarray_init(&encoder->fences, NULL);
}
VkResult
kk_encoder_init(mtl_device *device, struct kk_queue *queue,
struct kk_encoder **encoder)
{
assert(encoder && device && queue);
struct kk_encoder *enc = (struct kk_encoder *)malloc(sizeof(*enc));
if (!enc)
return VK_ERROR_OUT_OF_HOST_MEMORY;
memset(enc, 0u, sizeof(*enc));
enc->dev = device;
kk_encoder_start_internal(&enc->main, device, queue->main.mtl_handle);
kk_encoder_start_internal(&enc->pre_gfx, device, queue->pre_gfx.mtl_handle);
enc->event = mtl_new_event(device);
util_dynarray_init(&enc->imm_writes, NULL);
util_dynarray_init(&enc->resident_buffers, NULL);
util_dynarray_init(&enc->copy_query_pool_result_infos, NULL);
*encoder = enc;
return VK_SUCCESS;
}
mtl_render_encoder *
kk_encoder_start_render(struct kk_cmd_buffer *cmd,
mtl_render_pass_descriptor *descriptor,
uint32_t view_mask)
{
struct kk_encoder *encoder = cmd->encoder;
/* We must not already be in a render encoder */
assert(encoder->main.last_used != KK_ENC_RENDER ||
encoder->main.encoder == NULL);
if (encoder->main.last_used != KK_ENC_RENDER) {
kk_encoder_signal_fence_and_end(cmd);
/* Before we start any render operation we need to ensure we have the
* requried signals to insert pre_gfx execution before the render encoder
* in case we need to insert commands to massage input data for things
* like triangle fans. For this, we signal the value pre_gfx will wait on,
* and we wait on the value pre_gfx will signal once completed.
*/
encoder->signal_value_pre_gfx = encoder->event_value;
mtl_encode_signal_event(encoder->main.cmd_buffer, encoder->event,
++encoder->event_value);
encoder->wait_value_pre_gfx = encoder->event_value;
mtl_encode_wait_for_event(encoder->main.cmd_buffer, encoder->event,
++encoder->event_value);
encoder->main.encoder = mtl_new_render_command_encoder_with_descriptor(
encoder->main.cmd_buffer, descriptor);
if (encoder->main.wait_fence) {
mtl_render_wait_for_fence(
encoder->main.encoder,
util_dynarray_top(&encoder->main.fences, mtl_fence *));
encoder->main.wait_fence = false;
}
uint32_t layer_ids[KK_MAX_MULTIVIEW_VIEW_COUNT] = {};
uint32_t count = 0u;
u_foreach_bit(id, view_mask)
layer_ids[count++] = id;
if (view_mask == 0u) {
layer_ids[count++] = 0;
}
mtl_set_vertex_amplification_count(encoder->main.encoder, layer_ids,
count);
encoder->main.user_heap_hash = UINT32_MAX;
/* Bind read only data aka samplers' argument buffer. */
struct kk_device *dev = kk_cmd_buffer_device(cmd);
mtl_set_vertex_buffer(encoder->main.encoder, dev->samplers.table.bo->map,
0u, 1u);
mtl_set_fragment_buffer(encoder->main.encoder,
dev->samplers.table.bo->map, 0u, 1u);
}
encoder->main.last_used = KK_ENC_RENDER;
return encoder->main.encoder;
}
mtl_compute_encoder *
kk_encoder_start_compute(struct kk_cmd_buffer *cmd)
{
struct kk_encoder *encoder = cmd->encoder;
/* We must not already be in a render encoder */
assert(encoder->main.last_used != KK_ENC_RENDER ||
encoder->main.encoder == NULL);
struct kk_encoder_internal *enc = &encoder->main;
if (encoder->main.last_used != KK_ENC_COMPUTE) {
kk_encoder_signal_fence_and_end(cmd);
enc->encoder = mtl_new_compute_command_encoder(enc->cmd_buffer);
if (enc->wait_fence) {
mtl_compute_wait_for_fence(
enc->encoder, util_dynarray_top(&enc->fences, mtl_fence *));
enc->wait_fence = false;
}
enc->user_heap_hash = UINT32_MAX;
/* Bind read only data aka samplers' argument buffer. */
struct kk_device *dev = kk_cmd_buffer_device(cmd);
mtl_compute_set_buffer(enc->encoder, dev->samplers.table.bo->map, 0u, 1u);
}
encoder->main.last_used = KK_ENC_COMPUTE;
return encoder->main.encoder;
}
mtl_compute_encoder *
kk_encoder_start_blit(struct kk_cmd_buffer *cmd)
{
struct kk_encoder *encoder = cmd->encoder;
/* We must not already be in a render encoder */
assert(encoder->main.last_used != KK_ENC_RENDER ||
encoder->main.encoder == NULL);
struct kk_encoder_internal *enc = &encoder->main;
if (encoder->main.last_used != KK_ENC_BLIT) {
kk_encoder_signal_fence_and_end(cmd);
enc->encoder = mtl_new_blit_command_encoder(enc->cmd_buffer);
if (enc->wait_fence) {
mtl_compute_wait_for_fence(
enc->encoder, util_dynarray_top(&enc->fences, mtl_fence *));
enc->wait_fence = false;
}
}
encoder->main.last_used = KK_ENC_BLIT;
return encoder->main.encoder;
}
void
kk_encoder_end(struct kk_cmd_buffer *cmd)
{
assert(cmd);
kk_encoder_signal_fence_and_end(cmd);
/* Let remaining render encoders run without waiting since we are done */
mtl_encode_signal_event(cmd->encoder->pre_gfx.cmd_buffer,
cmd->encoder->event, cmd->encoder->event_value);
}
struct kk_imm_write_push {
uint64_t buffer_address;
uint32_t count;
};
void
upload_queue_writes(struct kk_cmd_buffer *cmd)
{
struct kk_encoder *enc = cmd->encoder;
struct kk_device *dev = kk_cmd_buffer_device(cmd);
uint32_t count = util_dynarray_num_elements(&enc->imm_writes, uint64_t) / 2u;
if (count != 0) {
mtl_compute_encoder *compute = kk_compute_encoder(cmd);
struct kk_bo *bo = kk_cmd_allocate_buffer(cmd, enc->imm_writes.size, 8u);
/* kk_cmd_allocate_buffer sets the cmd buffer error so we can just exit */
if (!bo)
return;
memcpy(bo->cpu, enc->imm_writes.data, enc->imm_writes.size);
uint32_t buffer_count =
util_dynarray_num_elements(&enc->resident_buffers, mtl_buffer *);
mtl_compute_use_resource(compute, bo->map, MTL_RESOURCE_USAGE_READ);
mtl_compute_use_resources(
compute, enc->resident_buffers.data, buffer_count,
MTL_RESOURCE_USAGE_READ | MTL_RESOURCE_USAGE_WRITE);
struct kk_imm_write_push push_data = {
.buffer_address = bo->gpu,
.count = count,
};
kk_cmd_dispatch_pipeline(cmd, compute,
kk_device_lib_pipeline(dev, KK_LIB_IMM_WRITE),
&push_data, sizeof(push_data), count, 1, 1);
enc->resident_buffers.size = 0u;
enc->imm_writes.size = 0u;
}
count = util_dynarray_num_elements(&enc->copy_query_pool_result_infos,
struct kk_copy_query_pool_results_info);
if (count != 0u) {
mtl_compute_encoder *compute = kk_compute_encoder(cmd);
uint32_t buffer_count =
util_dynarray_num_elements(&enc->resident_buffers, mtl_buffer *);
mtl_compute_use_resources(
compute, enc->resident_buffers.data, buffer_count,
MTL_RESOURCE_USAGE_READ | MTL_RESOURCE_USAGE_WRITE);
for (uint32_t i = 0u; i < count; ++i) {
struct kk_copy_query_pool_results_info *push_data =
util_dynarray_element(&enc->copy_query_pool_result_infos,
struct kk_copy_query_pool_results_info, i);
kk_cmd_dispatch_pipeline(
cmd, compute, kk_device_lib_pipeline(dev, KK_LIB_COPY_QUERY),
push_data, sizeof(*push_data), push_data->query_count, 1, 1);
}
enc->resident_buffers.size = 0u;
enc->copy_query_pool_result_infos.size = 0u;
}
/* All immediate write done, reset encoder */
kk_encoder_signal_fence_and_end(cmd);
}
void
kk_encoder_signal_fence_and_end(struct kk_cmd_buffer *cmd)
{
struct kk_encoder *encoder = cmd->encoder;
/* End pre_gfx */
if (encoder->pre_gfx.encoder) {
mtl_end_encoding(encoder->pre_gfx.encoder);
mtl_release(encoder->pre_gfx.encoder);
encoder->pre_gfx.encoder = NULL;
/* We can start rendering once all pre-graphics work is done */
mtl_encode_signal_event(encoder->pre_gfx.cmd_buffer, encoder->event,
encoder->event_value);
}
assert(encoder);
enum kk_encoder_type type = encoder->main.last_used;
struct kk_encoder_internal *enc = kk_encoder_get_internal(encoder, type);
if (!enc || !enc->encoder)
return;
mtl_fence *fence = mtl_new_fence(encoder->dev);
switch (type) {
case KK_ENC_RENDER:
mtl_render_update_fence(enc->encoder, fence);
break;
case KK_ENC_COMPUTE:
mtl_compute_update_fence(enc->encoder, fence);
break;
case KK_ENC_BLIT:
mtl_blit_update_fence(enc->encoder, fence);
break;
default:
assert(0);
break;
}
mtl_end_encoding(enc->encoder);
mtl_release(enc->encoder);
enc->encoder = NULL;
enc->last_used = KK_ENC_NONE;
enc->wait_fence = true;
util_dynarray_append(&enc->fences, mtl_fence *, fence);
if (cmd->drawable) {
mtl_present_drawable(enc->cmd_buffer, cmd->drawable);
cmd->drawable = NULL;
}
upload_queue_writes(cmd);
}
static void
kk_post_execution_release_internal(struct kk_encoder_internal *encoder)
{
mtl_release(encoder->cmd_buffer);
util_dynarray_foreach(&encoder->fences, mtl_fence *, fence)
mtl_release(*fence);
util_dynarray_fini(&encoder->fences);
}
static void
kk_post_execution_release(void *data)
{
struct kk_encoder *encoder = data;
kk_post_execution_release_internal(&encoder->main);
kk_post_execution_release_internal(&encoder->pre_gfx);
mtl_release(encoder->event);
util_dynarray_fini(&encoder->imm_writes);
util_dynarray_fini(&encoder->resident_buffers);
util_dynarray_fini(&encoder->copy_query_pool_result_infos);
free(encoder);
}
void
kk_encoder_submit(struct kk_encoder *encoder)
{
assert(encoder);
mtl_add_completed_handler(encoder->main.cmd_buffer,
kk_post_execution_release, encoder);
mtl_command_buffer_commit(encoder->pre_gfx.cmd_buffer);
mtl_command_buffer_commit(encoder->main.cmd_buffer);
}
mtl_render_encoder *
kk_render_encoder(struct kk_cmd_buffer *cmd)
{
struct kk_encoder *encoder = cmd->encoder;
/* Render encoders are created at vkBeginRendering only */
assert(encoder->main.last_used == KK_ENC_RENDER && encoder->main.encoder);
return (mtl_render_encoder *)encoder->main.encoder;
}
mtl_compute_encoder *
kk_compute_encoder(struct kk_cmd_buffer *cmd)
{
struct kk_encoder *encoder = cmd->encoder;
return encoder->main.last_used == KK_ENC_COMPUTE
? (mtl_blit_encoder *)encoder->main.encoder
: kk_encoder_start_compute(cmd);
}
mtl_blit_encoder *
kk_blit_encoder(struct kk_cmd_buffer *cmd)
{
struct kk_encoder *encoder = cmd->encoder;
return encoder->main.last_used == KK_ENC_BLIT
? (mtl_blit_encoder *)encoder->main.encoder
: kk_encoder_start_blit(cmd);
}
struct kk_encoder_internal *
kk_encoder_get_internal(struct kk_encoder *encoder, enum kk_encoder_type type)
{
switch (type) {
case KK_ENC_NONE:
assert(encoder->main.last_used == KK_ENC_NONE);
return NULL;
case KK_ENC_RENDER:
assert(encoder->main.last_used == KK_ENC_RENDER);
return &encoder->main;
case KK_ENC_COMPUTE:
assert(encoder->main.last_used == KK_ENC_COMPUTE);
return &encoder->main;
case KK_ENC_BLIT:
assert(encoder->main.last_used == KK_ENC_BLIT);
return &encoder->main;
default:
assert(0);
return NULL;
}
}
static mtl_compute_encoder *
kk_encoder_pre_gfx_encoder(struct kk_encoder *encoder)
{
if (!encoder->pre_gfx.encoder) {
/* Fast-forward all previous render encoders and wait for the last one */
mtl_encode_signal_event(encoder->pre_gfx.cmd_buffer, encoder->event,
encoder->signal_value_pre_gfx);
mtl_encode_wait_for_event(encoder->pre_gfx.cmd_buffer, encoder->event,
encoder->wait_value_pre_gfx);
encoder->pre_gfx.encoder =
mtl_new_compute_command_encoder(encoder->pre_gfx.cmd_buffer);
}
return encoder->pre_gfx.encoder;
}
struct kk_triangle_fan_info {
uint64_t index_buffer;
uint64_t out_ptr;
uint64_t in_draw;
uint64_t out_draw;
uint32_t restart_index;
uint32_t index_buffer_size_el;
uint32_t in_el_size_B;
uint32_t out_el_size_B;
uint32_t flatshade_first;
uint32_t mode;
};
static void
kk_encoder_render_triangle_fan_common(struct kk_cmd_buffer *cmd,
struct kk_triangle_fan_info *info,
mtl_buffer *indirect, mtl_buffer *index,
uint32_t index_count,
uint32_t in_el_size_B,
uint32_t out_el_size_B)
{
uint32_t index_buffer_size_B = index_count * out_el_size_B;
uint32_t buffer_size_B =
sizeof(VkDrawIndexedIndirectCommand) + index_buffer_size_B;
struct kk_bo *index_buffer =
kk_cmd_allocate_buffer(cmd, buffer_size_B, out_el_size_B);
if (!index_buffer)
return;
info->out_ptr = index_buffer->gpu + sizeof(VkDrawIndexedIndirectCommand);
info->out_draw = index_buffer->gpu;
info->in_el_size_B = in_el_size_B;
info->out_el_size_B = out_el_size_B;
info->flatshade_first = true;
mtl_compute_encoder *encoder = kk_encoder_pre_gfx_encoder(cmd->encoder);
if (index)
mtl_compute_use_resource(encoder, index, MTL_RESOURCE_USAGE_READ);
mtl_compute_use_resource(encoder, indirect, MTL_RESOURCE_USAGE_READ);
mtl_compute_use_resource(encoder, index_buffer->map,
MTL_RESOURCE_USAGE_WRITE);
struct kk_device *dev = kk_cmd_buffer_device(cmd);
kk_cmd_dispatch_pipeline(cmd, encoder,
kk_device_lib_pipeline(dev, KK_LIB_TRIANGLE_FAN),
info, sizeof(*info), 1u, 1u, 1u);
enum mtl_index_type index_type =
index_size_in_bytes_to_mtl_index_type(out_el_size_B);
mtl_render_encoder *enc = kk_render_encoder(cmd);
mtl_draw_indexed_primitives_indirect(
enc, cmd->state.gfx.primitive_type, index_type, index_buffer->map,
sizeof(VkDrawIndexedIndirectCommand), index_buffer->map, 0u);
}
void
kk_encoder_render_triangle_fan_indirect(struct kk_cmd_buffer *cmd,
mtl_buffer *indirect, uint64_t offset)
{
enum mesa_prim mode = cmd->state.gfx.prim;
uint32_t decomposed_index_count =
u_decomposed_prims_for_vertices(mode, cmd->state.gfx.vb.max_vertices) *
mesa_vertices_per_prim(mode);
uint32_t el_size_B = decomposed_index_count < UINT16_MAX ? 2u : 4u;
struct kk_triangle_fan_info info = {
.in_draw = mtl_buffer_get_gpu_address(indirect) + offset,
.restart_index = UINT32_MAX, /* No restart */
.mode = mode,
};
kk_encoder_render_triangle_fan_common(
cmd, &info, indirect, NULL, decomposed_index_count, el_size_B, el_size_B);
}
void
kk_encoder_render_triangle_fan_indexed_indirect(struct kk_cmd_buffer *cmd,
mtl_buffer *indirect,
uint64_t offset,
bool increase_el_size)
{
uint32_t el_size_B = cmd->state.gfx.index.bytes_per_index;
enum mesa_prim mode = cmd->state.gfx.prim;
uint32_t max_index_count =
(mtl_buffer_get_length(cmd->state.gfx.index.handle) -
cmd->state.gfx.index.offset) /
el_size_B;
uint32_t decomposed_index_count =
u_decomposed_prims_for_vertices(mode, max_index_count) *
mesa_vertices_per_prim(mode);
struct kk_triangle_fan_info info = {
.index_buffer = mtl_buffer_get_gpu_address(cmd->state.gfx.index.handle) +
cmd->state.gfx.index.offset,
.in_draw = mtl_buffer_get_gpu_address(indirect) + offset,
.restart_index =
increase_el_size ? UINT32_MAX : cmd->state.gfx.index.restart,
.index_buffer_size_el = max_index_count,
.mode = mode,
};
uint32_t out_el_size_B = increase_el_size ? sizeof(uint32_t) : el_size_B;
kk_encoder_render_triangle_fan_common(
cmd, &info, indirect, cmd->state.gfx.index.handle, decomposed_index_count,
el_size_B, out_el_size_B);
}
|